Rename constants.go to storagetypes.go 💎 #1730
Conversation
Creating a file called constants.go encourages folks to put all `const` values into this file, while I think it'll lead to better naming and code organization in the long run to try to name files and packages clearly after their contents. In this case I have a feeling that calling this storagetypes might actually hint that these values belong in another package entirely but that's a story for another day!
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XS
|
/test pull-tekton-pipeline-integration-tests |
There was a problem hiding this comment.
Creating a file called constants.go encourages folks to put all const
values into this file, while I think it'll lead to better naming and
code organization in the long run to try to name files and packages
clearly after their contents. In this case I have a feeling that calling
this storagetypes might actually hint that these values belong in
another package entirely but that's a story for another day!
I fully agree ! no need to be sorry 😉 🤗
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
Creating a file called constants.go encourages folks to put all
constvalues into this file, while I think it'll lead to better naming and
code organization in the long run to try to name files and packages
clearly after their contents. In this case I have a feeling that calling
this storagetypes might actually hint that these values belong in
another package entirely but that's a story for another day!
🙏 sorry not sorry @vdemeester 🙏
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.