Don't assume $0 is the script source #1808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Don't assume $0 is the script source
Part of our 'downstream' CI we reuse the
test/e2e-common.sh
functions.We have a script that source the test/e2e-common.sh and run with the downstream
specifics functions.
$0 in the e2e-common assume the script is run from
test/e2e-tests.sh
when ourscript which source test/e2e-tests.sh is something else somewhere else.
Let use git to safely detect the toplevel of the directory from where we can
source the vendor directory.
Remove latest go get from there too
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes