An example in the taskrun doc is not runnable #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
dibyom
approved these changes
Jan 13, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
afrittoli
reviewed
Jan 13, 2020
go.mod
Outdated
| @@ -4,6 +4,7 @@ go 1.13 | |||
|
|
|||
| require ( | |||
| cloud.google.com/go v0.47.0 // indirect | |||
| cloud.google.com/go/storage v1.0.0 | |||
There was a problem hiding this comment.
This change seems to be unrelated
go.mod
Outdated
| @@ -51,7 +52,7 @@ require ( | |||
| golang.org/x/sys v0.0.0-20191119060738-e882bf8e40c2 // indirect | |||
| golang.org/x/time v0.0.0-20191024005414-555d28b269f0 // indirect | |||
| golang.org/x/tools v0.0.0-20191118222007-07fc4c7f2b98 // indirect | |||
| google.golang.org/api v0.10.0 // indirect | |||
| google.golang.org/api v0.10.0 | |||
| - /bin/bash | ||
| args: | ||
| - "cat README.md" | ||
| script: cat workspace/README.md |
This commit fixes #1855 - an example in the taskrun doc is not runnable. Two changes were required to make this example in docs/taskruns.md runnable: 1. "cat README.md" needed to be updated to "cat workspace/README.md" because the git resource is checked out to /workspace/workspace 2. The TaskRun needed to be moved from above the resource and task declarations to be the last resource in the document. As an added bonus I've updated the example to use the script field instead of `bash -c $(args)`.
No problem, I've removed the changes to go.mod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #1855 - an example in the taskrun doc is not runnable.
Two changes were required to make this example in docs/taskruns.md
runnable:
"cat README.md" needed to be updated to "cat workspace/README.md"
because the git resource is checked out to /workspace/workspace
The TaskRun needed to be moved from above the resource and task
declarations to be the last resource in the document.
As an added bonus I've updated the example to use the script field
instead of
bash -c $(args).Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Includes tests (if functionality changed/added)