Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to cloudevents sdk v2 #2243

Merged
merged 1 commit into from
Mar 21, 2020
Merged

migrate to cloudevents sdk v2 #2243

merged 1 commit into from
Mar 21, 2020

Commits on Mar 20, 2020

  1. Migrate tekton to the cloudevents sdk v2 

    While I was here, I also refactored some of the CloudEvents integration, some major points:

you now send spec version 1.0 formatted events
ID is not the task run name, this was a bad idea if you want to send more than one event for that run. The task run name is now used as the subject.
ID is now a UUID.
The event that is created for sending is only created once, and then used for all deliveries. This means that all subscribers get the same event content and ID.
The event payload is marshaled inside the Event object. I show examples in the code and tests of how to set and get the payload as your custom struct.
Removed a lot of the layers passing clients and event components around. Better to build the event and then call send on the client directly. This deleted a lot of code that was doing many things, like create an event, and then attempt to send it.

Signed-off-by: Scott Nichols <[email protected]>
    Scott Nichols committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    4202b69 View commit details
    Browse the repository at this point in the history