Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the TaskRuns documentation for clarity and flow. #2341

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Rewrite the TaskRuns documentation for clarity and flow. #2341

merged 1 commit into from
Apr 22, 2020

Conversation

tualeron
Copy link
Contributor

@tualeron tualeron commented Apr 6, 2020

Rewrites the TaskRuns documentation for clarity and flow.

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 6, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 6, 2020
@vdemeester
Copy link
Member

/cc @nkakkar81

@tekton-robot
Copy link
Collaborator

@vdemeester: GitHub didn't allow me to request PR reviews from the following users: nkakkar81.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @nkakkar81

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost ghost added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 17, 2020
ghost
ghost approved these changes Apr 17, 2020
View reviewed changes
docs/taskruns.md Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
nkakkar81
nkakkar81 reviewed Apr 20, 2020
View reviewed changes
docs/taskruns.md Show resolved Hide resolved
docs/taskruns.md Outdated Show resolved Hide resolved
docs/taskruns.md Outdated Show resolved Hide resolved
docs/taskruns.md Outdated Show resolved Hide resolved
docs/taskruns.md Show resolved Hide resolved
docs/taskruns.md Outdated Show resolved Hide resolved
docs/taskruns.md Outdated Show resolved Hide resolved
docs/taskruns.md Show resolved Hide resolved
@dlorenc
Copy link
Contributor

dlorenc commented Apr 22, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@vdemeester vdemeester removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@vdemeester
Copy link
Member

@sergetron you're gonna need to amend/force-push to make the easycla check re-run.. (I think it happened because of the GitHub outage yesterday..)

@tualeron
Copy link
Contributor Author

/retest

@popcor255
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@tualeron
Rewrite the TaskRuns documentation for clarity and flow.
69b737f 
Rewrite the TaskRuns documentation for clarity and flow.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@tualeron
Copy link
Contributor Author

Did an amend+push. Can someone re-LGTM?

@ghost
Copy link

ghost commented Apr 22, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Apr 22, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@tualeron
Copy link
Contributor Author

tualeron commented Apr 22, 2020 via email

@tualeron
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot merged commit 8b4f7c8 into tektoncd:master Apr 22, 2020
@tualeron tualeron deleted the patch-4 branch April 22, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkakkar81 nkakkar81 nkakkar81 left review comments

@imjasonh imjasonh Awaiting requested review from imjasonh

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@dlorenc dlorenc

@popcor255 popcor255

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tualeron @vdemeester @tekton-robot @dlorenc @popcor255 @nkakkar81 @googlebot