Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to the Workspaces doc from docs/README.md #2352

Merged
merged 1 commit into from Apr 8, 2020
Merged

Add a link to the Workspaces doc from docs/README.md #2352

merged 1 commit into from Apr 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2020

Changes

We recently introduced a workspaces doc to help consolidate
the disparate info spread across the other docs.

This commit adds a link to our docs/README.md index to
help surface workspace information. Further, it reorders
the index just a bit so that Workspaces & PipelineResources
appear next to each other without pushing the PipelineRun
doc further down in the list.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

We recently introduced a workspaces doc to help consolidate
the disparate info spread across the other docs.

This commit adds a link to our docs/README.md index to
help surface workspace information. Further, it reorders
the index just a bit so that Workspaces & PipelineResources
appear next to each other without pushing the PipelineRun
doc further down in the list.
@ghost ghost added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Apr 8, 2020
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 8, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@ghost
Copy link
Author

ghost commented Apr 8, 2020

/test pull-tekton-pipeline-build-tests

@tekton-robot tekton-robot merged commit 4957eec into tektoncd:master Apr 8, 2020
@ghost ghost removed the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants