Fix default-timeout-minutes from Config Not Being Set Correctly for v1alpha1 #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/S
|
The following is the coverage report on pkg/.
|
ghost
approved these changes
Apr 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a follow up of #2333 and #2324. #2333 fixed #2324 for
v1beta1PipelineRuns/TaskRuns not having thedefault-timeout-minutescorrectly applied. Unfortunately, this issue will still apply tov1alpha1PipelineRuns/TaskRuns.This pull request fixes this issue by applying the same changes from #2333 to
v1alpha1PipelineRun/TaskTun defaults.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes