Add DAG tests for v1beta1 as well as v1alpha1 📈 #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for tektoncd#2463 made sure that we use the same Deps logic for both v1alpha1 and v1beta1 types. This DAG test is the closest thing that Deps has to unit test. I meant to include this test in tektoncd@45ef5d7 but forgot to add it!! This test would be only temporary since after tektoncd#2410 we won't need to duplicated any of this logic, but it seems useful to have in the meantime. (Or until we add unit tests for Deps!!)
tekton-robot
added
the
size/XL
|
/approve |
tekton-robot
added
lgtm
vdemeester
approved these changes
Apr 23, 2020
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The fix for #2463 made sure that we use the same Deps logic for both
v1alpha1 and v1beta1 types. This DAG test is the closest thing that Deps
has to unit test.
I meant to include this test in
45ef5d7
but forgot to add it!!
This test would be only temporary since after #2410 we won't need to
duplicated any of this logic, but it seems useful to have in the
meantime. (Or until we add unit tests for Deps!!)
This is an exact copy of the v1alpha1 tests but with v1beta1 types.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.