Fixing codegen scripts 😅 #2486
Merged
Fixing codegen scripts 😅 #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/work-in-progress
vdemeester
force-pushed
the
codegen-fix
branch
2 times, most recently
from
0bfed81
to
b753922
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
chmouel
reviewed
Apr 24, 2020
hack/update-codegen.sh
Outdated
| @@ -18,6 +18,8 @@ set -o errexit | |||
| set -o nounset | |||
| set -o pipefail | |||
|
|
|||
| set -x | |||
There was a problem hiding this comment.
is that intentional to be kept? (it's going to be more verbose)
There was a problem hiding this comment.
right, I should remove it, but I wanted to make sure it passes before 😅
|
/lgtm |
`go install` install binaries either in `$GOBIN` or `$GOPATH/bin`. This means, you can do a `go install` and *hard code* `$GOPATH/bin` to find the installed binaries. As, in any case, this folder is usually in the `$PATH`, we can just rely on that. Signed-off-by: Vincent Demeester <[email protected]>
|
/lgtm Looking Good! 🤙🏽 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For some reason it fails on the:latestimages…go installinstall binaries either in$GOBINor$GOPATH/bin. This means, you can do ago installand hard code$GOPATH/binto find the installed binaries.As, in any case, this folder is usually in the
$PATH, we can justrely on that.
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.