Makefile: add bin/*, resolve and watch-resolve target 🚕 #2569
Conversation
Those targets are there to build binaries using `go` and the images using `ko resolve` without applying the changes. Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
added
kind/misc
| KO = $(BIN)/ko | ||
| $(BIN)/ko: PACKAGE=github.com/google/ko/cmd/ko | ||
|
|
||
| .PHONY: apply | ||
| apply: | $(KO) ; $(info $(M) ko apply -f config/) @ ## Apply config to the current cluster | ||
| $Q $(KO) apply --strict -f config | ||
| $Q $(KO) apply -f config |
There was a problem hiding this comment.
why did you remove the --strict, is that intentional?
There was a problem hiding this comment.
Yes and no 😅 With --strict, it doesn't build any image for me (for some weird reason).
There was a problem hiding this comment.
--strict should only filter out things prefixed with ko://, so if you are seeing stuff that is prefixed not building we should talk :)
There was a problem hiding this comment.
@mattmoor just realized why… ko:// got temporarly remove because of ko-build/ko#164 I think 😝 hence why it doesn't build a thing 😝
There was a problem hiding this comment.
maybe you could add the strict as an option?
This runs the ./hack scripts. Signed-off-by: Vincent Demeester <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
Those targets are there to build binaries using
goand the imagesusing
ko resolvewithout applying the changes.This also adds a
generatedtarget.Signed-off-by: Vincent Demeester [email protected]
/kind misc
/cc @afrittoli @sbwsg
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes