Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google/ko 5.0+ requires images to be prefixed by ko:// . #2675

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Google/ko 5.0+ requires images to be prefixed by ko:// . #2675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions config/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,17 @@ spec:
serviceAccountName: tekton-pipelines-controller
containers:
- name: tekton-pipelines-controller
image: github.com/tektoncd/pipeline/cmd/controller
image: ko://github.com/tektoncd/pipeline/cmd/controller
args: [
# These images are built on-demand by `ko resolve` and are replaced
# by image references by digest.
"-kubeconfig-writer-image", "github.com/tektoncd/pipeline/cmd/kubeconfigwriter",
"-creds-image", "github.com/tektoncd/pipeline/cmd/creds-init",
"-git-image", "github.com/tektoncd/pipeline/cmd/git-init",
"-entrypoint-image", "github.com/tektoncd/pipeline/cmd/entrypoint",
"-imagedigest-exporter-image", "github.com/tektoncd/pipeline/cmd/imagedigestexporter",
"-pr-image", "github.com/tektoncd/pipeline/cmd/pullrequest-init",
"-build-gcs-fetcher-image", "github.com/tektoncd/pipeline/vendor/github.com/GoogleCloudPlatform/cloud-builders/gcs-fetcher/cmd/gcs-fetcher",
"-kubeconfig-writer-image", "ko://github.com/tektoncd/pipeline/cmd/kubeconfigwriter",
"-creds-image", "ko://github.com/tektoncd/pipeline/cmd/creds-init",
"-git-image", "ko://github.com/tektoncd/pipeline/cmd/git-init",
"-entrypoint-image", "ko://github.com/tektoncd/pipeline/cmd/entrypoint",
"-imagedigest-exporter-image", "ko://github.com/tektoncd/pipeline/cmd/imagedigestexporter",
"-pr-image", "ko://github.com/tektoncd/pipeline/cmd/pullrequest-init",
"-build-gcs-fetcher-image", "ko://github.com/tektoncd/pipeline/vendor/github.com/GoogleCloudPlatform/cloud-builders/gcs-fetcher/cmd/gcs-fetcher",

# This image is used as a placeholder pod, the Affinity Assistant
# TODO(#2640) We may want to create a custom, minimal binary
Expand Down
2 changes: 1 addition & 1 deletion config/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ spec:
- name: webhook
# This is the Go import path for the binary that is containerized
# and substituted here.
image: github.com/tektoncd/pipeline/cmd/webhook
image: ko://github.com/tektoncd/pipeline/cmd/webhook
env:
- name: SYSTEM_NAMESPACE
valueFrom:
Expand Down