Updates to release docs 📝 #2765
Conversation
While creating 0.13 I changed a few things: * I made the env vars used in the release docs match the ones in the draft release docs https:/tektoncd/plumbing/blob/master/tekton/resources/release/README.md#create-draft-release so you can use the same for both * I moved the "post processing services" step out of the "how to run the pipelines release" flow b/c when I tried going through these steps I was confused by it and after investigating it turns out this already exists, so it doesnt seem like it has to be added every time (though looking at the pipelineruns, it doesnt seem like anything got triggered by the release pipeline after all?) * I updated a couple links to the dogfooding cluster instead of the prow cluster where we used to run these
tekton-robot
added
the
size/M
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
1 similar comment
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
/kind documentation |
tekton-robot
added
the
kind/documentation
| export IMAGE_REGISTRY=gcr.io/tekton-releases | ||
|
|
||
| # Double-check the git revision that is going to be used for the release: | ||
| kubectl get pipelineresource/tekton-pipelines-git-vX-Y-Z -o=jsonpath="{'Target Revision: '}{.spec.params[?(@.name == 'revision')].value}{'\n'}" | ||
| kubectl get pipelineresource/$TEKTON_RELEASE_GIT_RESOURCE -o=jsonpath="{'Target Revision: '}{.spec.params[?(@.name == 'revision')].value}{'\n'}" | ||
|
|
||
| # Execute the release pipeline. | ||
| # By default this will tag the release as Pipelines' latest. If you would like to prevent | ||
| # this from happening add --param=releaseAsLatest="false" |
There was a problem hiding this comment.
It did come up as a pre-release this time.
There was a problem hiding this comment.
I think it always comes at pre-release. This param is for being able to release older fix release (like a 0.12.2 while 0.13.0 has been already released)
tekton-robot
added
the
approved
| export VERSION_TAG=vX.Y.Z | ||
| export GIT_RESOURCE_NAME=tekton-pipelines-git-vX-Y-Z | ||
| export TEKTON_VERSION=vX.Y.Z | ||
| export TEKTON_RELEASE_GIT_RESOURCE=tekton-pipelines-git-vX-Y-Z |
There was a problem hiding this comment.
This could even be export TEKTON_RELEASE_GIT_RESOURCE=tekton-pipelines-git-${TEKTON_VERSION} 😝
| export IMAGE_REGISTRY=gcr.io/tekton-releases | ||
|
|
||
| # Double-check the git revision that is going to be used for the release: | ||
| kubectl get pipelineresource/tekton-pipelines-git-vX-Y-Z -o=jsonpath="{'Target Revision: '}{.spec.params[?(@.name == 'revision')].value}{'\n'}" | ||
| kubectl get pipelineresource/$TEKTON_RELEASE_GIT_RESOURCE -o=jsonpath="{'Target Revision: '}{.spec.params[?(@.name == 'revision')].value}{'\n'}" | ||
|
|
||
| # Execute the release pipeline. | ||
| # By default this will tag the release as Pipelines' latest. If you would like to prevent | ||
| # this from happening add --param=releaseAsLatest="false" |
There was a problem hiding this comment.
I think it always comes at pre-release. This param is for being able to release older fix release (like a 0.12.2 while 0.13.0 has been already released)
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
While creating 0.13 I changed a few things:
draft release docs https:/tektoncd/plumbing/blob/master/tekton/resources/release/README.md#create-draft-release
so you can use the same for both
the pipelines release" flow b/c when I tried going through these steps
I was confused by it and after investigating it turns out this already
exists, so it doesnt seem like it has to be added every time (though
looking at the pipelineruns, it doesnt seem like anything got
triggered by the release pipeline after all?)
cluster where we used to run these
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.