Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in conditional examples #2782

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Fix typo in conditional examples #2782

merged 1 commit into from
Jun 24, 2020

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Jun 8, 2020

Changes

Adds the missing i.

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jun 8, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@pritidesai
Copy link
Member

😸
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
vdemeester
vdemeester approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@dibyom
Copy link
Member Author

dibyom commented Jun 18, 2020

gosec is on a roll today! (see tektoncd/triggers#597 as well!)

===============================
==== RUNNING GOLANGCI-LINT ====
===============================
pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go:690:16: G601: Implicit memory aliasing in for loop. (gosec)
				in, out := &val, &outVal
				           ^
pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go:736:16: G601: Implicit memory aliasing in for loop. (gosec)
				in, out := &val, &outVal
				           ^
pkg/pod/status.go:119:37: G601: Implicit memory aliasing in for loop. (gosec)
				if err := updateStatusStartTime(&s); err != nil {
				                                ^
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go:237:46: G601: Implicit memory aliasing in for loop. (gosec)
		r, err := resources.GetResourceFromBinding(&resource, getResource)

@dibyom
Copy link
Member Author

dibyom commented Jun 19, 2020

/test pull-tekton-pipeline-build-tests

@bobcatfish bobcatfish mentioned this pull request Jun 19, 2020
Closed
@bobcatfish
Copy link
Collaborator

Looks like a flake! Opened #2840

/test pull-tekton-pipeline-integration-tests

@bobcatfish
Copy link
Collaborator 

Expected 2 number of successful events from pipelinerun and taskrun but got 3; list of receieved events

wut

/test pull-tekton-pipeline-integration-tests

@pritidesai
Copy link
Member

/test pull-tekton-pipeline-integration-tests

5 similar comments
@ghost
Copy link

ghost commented Jun 22, 2020

/test pull-tekton-pipeline-integration-tests

@dibyom
Copy link
Member Author

dibyom commented Jun 22, 2020

/test pull-tekton-pipeline-integration-tests

@dibyom
Copy link
Member Author

dibyom commented Jun 22, 2020

/test pull-tekton-pipeline-integration-tests

@vdemeester
Copy link
Member

/test pull-tekton-pipeline-integration-tests

@pritidesai
Copy link
Member

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot merged commit 8eb254d into tektoncd:master Jun 24, 2020
@dibyom dibyom deleted the typo branch June 29, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dibyom @tekton-robot @pritidesai @bobcatfish @vdemeester