-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add credentials to pipelines' roadmap #2858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
/cc @afrittoli @bobcatfish
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @sbwsg ! +1 from me - would be great to get a couple more OWNERS to lgtm before we merge since it's a roadmap change @imjasonh @afrittoli @dlorenc @dibyom im also not sure if the meow means you agree or not @vdemeester but im guessing it does XD |
@@ -43,6 +43,8 @@ Tekton: | |||
- [Adding support for other architectures](https:/tektoncd/pipeline/issues/856) | |||
- [Rich type support for params](https:/tektoncd/pipeline/issues/1393) | |||
- Looping syntax (in [Tasks](https:/tektoncd/pipeline/issues/2112) and/or [Pipelines](https:/tektoncd/pipeline/issues/2050))- either implement or decide it is outside of scope (i.e. better suited for a DSL) | |||
- [Supplying credentials for authenticated actions in Tasks](https:/tetkoncd/pipeline/issues/2343) - documented guidelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: tekton :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hand wrote the url 😱 fixed. thanks!
Strong +1 to adding this from me! |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/meow
/lgtm
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ahah yes I do agree 😉 |
/retest |
Getting credentials into Tasks is currently supported via multiple mechanisms, each with its own set of tradeoffs and level of support within Tekton Pipelines. This PR adds credentials to our roadmap with intent to improve both upon the implemented feature set and the documented guidance to credential handling that Pipelines already offers.
/lgtm |
I'm gonna remove the hold - if has strong feelings that they haven't expressed yet we can always modify :D /hold cancel |
Changes
Getting credentials into Tasks is currently supported via multiple
mechanisms, each with its own set of tradeoffs and level of support
within Tekton Pipelines.
This PR adds credentials to our roadmap with intent to improve both upon
the implemented feature set and the documented guidance to credential handling
that Pipelines already offers.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: