Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credentials to pipelines' roadmap #2858

Merged
merged 1 commit into from Jun 26, 2020
Merged

Add credentials to pipelines' roadmap #2858

merged 1 commit into from Jun 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 24, 2020

Changes

Getting credentials into Tasks is currently supported via multiple
mechanisms, each with its own set of tradeoffs and level of support
within Tekton Pipelines.

This PR adds credentials to our roadmap with intent to improve both upon
the implemented feature set and the documented guidance to credential handling
that Pipelines already offers.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

@ghost ghost added kind/documentation Categorizes issue or PR as related to documentation. area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) labels Jun 24, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 24, 2020
@ghost ghost requested a review from bobcatfish June 24, 2020 17:37
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow
/cc @afrittoli @bobcatfish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@bobcatfish
Copy link
Collaborator

Thanks @sbwsg ! +1 from me - would be great to get a couple more OWNERS to lgtm before we merge since it's a roadmap change

@imjasonh @afrittoli @dlorenc @dibyom

im also not sure if the meow means you agree or not @vdemeester but im guessing it does XD

@@ -43,6 +43,8 @@ Tekton:
- [Adding support for other architectures](https:/tektoncd/pipeline/issues/856)
- [Rich type support for params](https:/tektoncd/pipeline/issues/1393)
- Looping syntax (in [Tasks](https:/tektoncd/pipeline/issues/2112) and/or [Pipelines](https:/tektoncd/pipeline/issues/2050))- either implement or decide it is outside of scope (i.e. better suited for a DSL)
- [Supplying credentials for authenticated actions in Tasks](https:/tetkoncd/pipeline/issues/2343) - documented guidelines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: tekton :D

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hand wrote the url 😱 fixed. thanks!

@dibyom
Copy link
Member

dibyom commented Jun 24, 2020

Strong +1 to adding this from me!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@dibyom
Copy link
Member

dibyom commented Jun 24, 2020

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/meow
/lgtm

@tekton-robot
Copy link
Collaborator

@afrittoli: cat image

In response to this:

Thanks!
/meow
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

ahah yes I do agree 😉

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@afrittoli
Copy link
Member

/retest
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
Getting credentials into Tasks is currently supported via multiple
mechanisms, each with its own set of tradeoffs and level of support
within Tekton Pipelines.

This PR adds credentials to our roadmap with intent to improve both upon
the implemented feature set and the documented guidance to credential handling
that Pipelines already offers.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@bobcatfish
Copy link
Collaborator

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@bobcatfish
Copy link
Collaborator

I'm gonna remove the hold - if has strong feelings that they haven't expressed yet we can always modify :D

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2020
@tekton-robot tekton-robot merged commit 41869d7 into tektoncd:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants