Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit event only once #2860

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Emit event only once #2860

merged 1 commit into from
Jun 24, 2020

Commits on Jun 24, 2020

  1. Emit event only once 

    When finishReconcileUpdateEmitEvents was introduced in PR tektoncd#2805,
I forgot to remove one of the original event.Emit, so one event
was sent twice. The fake recorder sometimes probably recognised
the duplicate and filtered it out, causing flackiness in tests,
as unit tests expect a fixed number of events.

Thanks @GregDritschler for troubleshooting this!

Fixes: tektoncd#2857
    @afrittoli
    afrittoli committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    4ecf025 View commit details
    Browse the repository at this point in the history