Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expansion of context.(pipeline|pipelinerun|task|taskRun).name and add tests #2880

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Add expansion of context.(pipeline|pipelinerun|task|taskRun).name and add tests #2880

merged 1 commit into from
Jul 1, 2020

Conversation

R2wenD2
Copy link
Contributor

@R2wenD2 R2wenD2 commented Jun 30, 2020 •
edited
Loading

Changes

Add expansion of context.(pipeline|pipelinerun|task|taskRun).name and add tests and documentation. This addresses #1522

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [X ] Includes tests (if functionality changed/added)
  • [X ] Includes docs (if user facing)
  • [ X] Commit messages follow commit message best practices
  • [ X] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes


$context.(task|taskRun|pipeline|pipelineRun).name can be used to reference the appropriate name when in pipelineRuns and taskRuns

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 30, 2020
@R2wenD2 R2wenD2 changed the title Add expansion of context.(pipeline|pipelinerun|task|taskRun).name and Add expansion of context.(pipeline|pipelinerun|task|taskRun).name and add tests Jun 30, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

1 similar comment
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 85.9% 86.0% 0.0
pkg/reconciler/taskrun/taskrun.go 76.5% 76.6% 0.1

@R2wenD2
Copy link
Contributor Author

R2wenD2 commented Jun 30, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 30, 2020
imjasonh
imjasonh reviewed Jul 1, 2020
View reviewed changes
pkg/reconciler/pipelinerun/resources/apply.go Show resolved Hide resolved
pkg/reconciler/taskrun/resources/apply.go Show resolved Hide resolved
pkg/reconciler/taskrun/resources/apply.go
func ApplyContexts(spec *v1beta1.TaskSpec, rtr *ResolvedTaskResources, tr *v1beta1.TaskRun) *v1beta1.TaskSpec {
stringReplacements := map[string]string{}
stringReplacements["context.taskRun.name"] = tr.Name
stringReplacements["context.task.name"] = rtr.TaskName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double-check, if I'm defining a TaskRun's TaskSpec inline, there won't be a Task name, and this context value will be "", right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, and I added a testcase to confirm.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 85.9% 86.0% 0.0
pkg/reconciler/taskrun/taskrun.go 76.5% 76.6% 0.1

imjasonh
imjasonh approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@tekton-robot tekton-robot merged commit 08ac72c into tektoncd:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@imjasonh imjasonh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@R2wenD2 @tekton-robot @imjasonh