Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: host.docker.internal instead of host.docker.local #2993

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Fix: host.docker.internal instead of host.docker.local #2993

merged 1 commit into from
Jul 24, 2020

Conversation

juanri0s
Copy link

@juanri0s juanri0s commented Jul 23, 2020 •
edited
Loading

Changes

Tutorial.md says to use "host.docker.local" instead of "host.docker.internal" #2970

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

/kind documentation

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 23, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 23, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2020
@tekton-robot
Copy link
Collaborator

Hi @juanri0s. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2020
@juanri0s
Copy link
Author

/assign @dlorenc

@pritidesai
Copy link
Member

Welcome and Thank you @juanri0s for this contribution 🙏

/ok-to-test
/release-note-none

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/documentation Categorizes issue or PR as related to documentation. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2020
vdemeester
vdemeester approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2020
@dlorenc
Copy link
Contributor

dlorenc commented Jul 23, 2020

Thanks for the commit!

@dlorenc
Copy link
Contributor

dlorenc commented Jul 23, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@dlorenc
Copy link
Contributor

dlorenc commented Jul 23, 2020

/kind documentation

The kind check appears stuck, let's poke it and see...

@vdemeester vdemeester removed the kind/documentation Categorizes issue or PR as related to documentation. label Jul 23, 2020
@vdemeester
Copy link
Member

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 23, 2020
@juanri0s
Copy link
Author

did I break it lol

@vdemeester
Copy link
Member

@juanri0s nah, something seems fishy, invoking @afrittoli to dig into the why it seems stuck 😝

@vdemeester vdemeester removed the kind/documentation Categorizes issue or PR as related to documentation. label Jul 24, 2020
@vdemeester vdemeester added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 24, 2020
@tekton-robot tekton-robot merged commit e692b98 into tektoncd:master Jul 24, 2020
@dlorenc dlorenc mentioned this pull request Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@dlorenc dlorenc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juanri0s @tekton-robot @pritidesai @dlorenc @vdemeester