Controlling max parallel jobs per pipeline[WIP]

[NikeNano]

This PR adds logic to allow for a maximum nbr of parallel task to run concurrency. This is done by validating how many task is runing before a new task is runing. If there are more than the set maximum the controller omit creating a new.

Changes

This PR updates the PipelineRun controller to check how TaskRuns are running for the PipelineRun and if it is more concurrent jobs than a limit specified in the PipelineRunSpec the TaskRun will not be created.

This is related to: #2591 and more specifically this comment: #2591 (comment)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign afrittoli
You can assign the PR to them by writing /assign @afrittoli in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

Hi @NikeNano. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[NikeNano]

@jlpettersson I read your comment on how to solve #2591, do you have to possibility to review this WIP? Thanks

[jerop]

@NikeNano this issue might need a TEP so that we can discuss the change

cc @bobcatfish

[NikeNano]

Thanks @jerop, I will create a TEP

@NikeNano this issue might need a TEP so that we can discuss the change

[NikeNano]

FYI: Have to do this after vacation so will take a week or two.

[jerop]

@NikeNano do you plan to write a TEP for this? there's more related discussion in #1305 that could be helpful -- happy to help with the TEP if needed

/kind feature

[NikeNano]

Thank you for the ping @jerop! Missed this after the vacation. Will pick it up, would be great with some help. I will create a draft and tag you.

[ghost]

/retest

[tekton-robot]

@NikeNano: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-pipeline-unit-tests	4dd4a63	link	/test tekton-pipeline-unit-tests
pull-tekton-pipeline-build-tests	4dd4a63	link	/test pull-tekton-pipeline-build-tests
pull-tekton-pipeline-integration-tests	4dd4a63	link	/test pull-tekton-pipeline-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tekton-robot]

@NikeNano: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[javlonsodikov]

hello Team

Any news on this issue? we need parallel runs in the project