adding unit tests for pipelineTaskList.Deps #3597
Conversation
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
thanks for adding these tests @pritidesai!
given that you also fixed the check for uniqueness of deps, maybe we can add a test that has duplicate deps and validate that the elements in the deps list are unique...
pritidesai
force-pushed
the
deps-unit-test
branch
from
b2aaa64
to
1caab42
Compare
|
The following is the coverage report on the affected files.
|
Good point @jerop, it had a check where the same task ( |
|
Looks like this might be more instances of #2656 /test pull-tekton-pipeline-integration-tests |
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adding unit tests to validate pipelineTaskList.Deps returning correct depedencies. Changing orderingDeps() to avoid calling resourceDeps() and checking for duplicates since Deps() returns a unique set of dependencies for any pipelineTask.
pritidesai
force-pushed
the
deps-unit-test
branch
from
1caab42
to
9ef50e2
Compare
|
The following is the coverage report on the affected files.
|
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
|
/lgtm |
|
/test check-pr-has-kind-label |
ghost
removed
the
Changes
Adding unit tests to validate
pipelineTaskList.Deps()returning correct dependencies.Changing
orderingDeps()to avoid callingresourceDeps()and checking for duplicates sincepipelineTaskList.Dep()returns a unique set of dependencies (usingsets) for allpipelineTasks./kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes