Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template spring cleaning 🌷 #3866

Merged
merged 1 commit into from
Apr 5, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 8 additions & 19 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
# Changes

<!--
Describe your changes here- ideally you can get that description straight from
your descriptive commit message(s)!
Describe your changes here- ideally you can get that description straight from your descriptive commit message(s)!

In addition, categorize the changes you're making using the "/kind" Prow command, example:

Expand All @@ -15,24 +14,14 @@ Supported kinds are: bug, cleanup, design, documentation, failing-test, feature,

# Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:
As the author of this PR, please check off the items in this checklist:

- [ ] Includes [tests](https:/tektoncd/community/blob/master/standards.md#principles) (if functionality changed/added)
- [ ] Includes [docs](https:/tektoncd/community/blob/master/standards.md#principles) (if user facing)
- [ ] Commit messages follow [commit message best practices](https:/tektoncd/community/blob/master/standards.md#commit-messages)
- [ ] Release notes block has been filled in or deleted (only if no user facing changes)

_See [the contribution guide](https:/tektoncd/pipeline/blob/master/CONTRIBUTING.md) for more details._

Double check this list of stuff that's easy to miss:

- If you are adding [a new binary/image to the `cmd` dir](../cmd), please update
[the release Task](../tekton/publish.yaml) to build and release this image.

## Reviewer Notes

If [API changes](https:/tektoncd/pipeline/blob/master/api_compatibility_policy.md) are included, [additive changes](https:/tektoncd/pipeline/blob/master/api_compatibility_policy.md#additive-changes) must be approved by at least two [OWNERS](https:/tektoncd/pipeline/blob/master/OWNERS) and [backwards incompatible changes](https:/tektoncd/pipeline/blob/master/api_compatibility_policy.md#backwards-incompatible-changes) must be approved by [more than 50% of the OWNERS](https:/tektoncd/pipeline/blob/master/OWNERS), and they must first be added [in a backwards compatible way](https:/tektoncd/pipeline/blob/master/api_compatibility_policy.md#backwards-compatible-changes-first).
- [ ] [Docs](https:/tektoncd/community/blob/main/standards.md#docs) included if any changes are user facing
- [ ] [Tests](https:/tektoncd/community/blob/main/standards.md#tests) included if any functionality added or changed
- [ ] Follows the [commit message standard](https:/tektoncd/community/blob/main/standards.md#commits)
- [ ] Meets the [Tekton contributor standards](https:/tektoncd/community/blob/main/standards.md) (including
functionality, content, code)
- [ ] Release notes block below has been filled in or deleted (only if no user facing changes)

# Release Notes

Expand Down