Remove confusing comment (◎_◎;) #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jerop was walking through this code in a meeting and I noticed this comment for a few reasons: - it's at the end of the line v.s. above the line which is kind of abnormal - it's referring to some specific code shape at some point in time which seems like something that will fall out of sync quickly - in fact im not sure what the `t.Skip` is that it is referring to - it seems to be the function that `t.skip` is being called from?? After trying to understand it more it not only doesn't seem to be adding anything useful, I'm actually not sure what it means (maybe it was included from some WIP refactoring to help the author?) Anyway if anyone knows more or feels like this should stay maybe we can update it :D
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XS
jerop
approved these changes
Aug 18, 2021
tekton-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@jerop was walking through this code in a meeting and I noticed this
comment for a few reasons:
seems like something that will fall out of sync quickly
t.Skipis that it is referring to - itseems to be the function that
t.skipis being called from??After trying to understand it more it not only doesn't seem to be adding
anything useful, I'm actually not sure what it means (maybe it was
included from some WIP refactoring to help the author?)
Anyway if anyone knows more or feels like this should stay maybe we can
update it :D
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes