Un-randomize TestConvertScripts_WithBreakpoint_OnFailure #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit we iterated over a map when building up the args passed to a step container with debug breakpoint enabled. Map iteration can be random, so sometimes our unit tests would flake out. This commit switches the map to a list and uses a struct to provide the fields as the key/values from the map.
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
|
/kind bug |
ghost
requested a review
from 
ghost
added
kind/bug
|
/test check-pr-has-kind-label |
vdemeester
approved these changes
Aug 30, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #4167
Prior to this commit we iterated over a map when building up the args
passed to a step container with debug breakpoint enabled. Map iteration
can be random, so sometimes our unit tests would flake out.
This commit switches the map to a list and uses a struct to provide
the fields as the key/values from the map.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes