TEP-0090: Refactor Validation of Parameters in TaskRun Reconciler
#4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this change, we refactor the function that validates `Parameters` in the `TaskRun` reconciler in preparation for changes related to `Matrix`. The refactor mainly involves splitting up the lengthy function to make it easier to understand, maintain and reuse parts of the logic. There are no functional changes.
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
/retest |
lbernick
approved these changes
May 6, 2022
|
/test pull-tekton-pipeline-go-coverage |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
5 tasks
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
May 6, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reonciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. Related refactors were done in tektoncd#4841.
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
May 6, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. Related refactors were done in tektoncd#4841.
5 tasks
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
May 6, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. Related refactors were done in tektoncd#4841.
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
May 6, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. This includes validating that `Parameters` in the `Matrix` field are `Arrays` only, and that they are subsituting `Parameters` of type `String` in the underlying `Task`. Related refactors were done in tektoncd#4841.
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
May 6, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. This includes validating that `Parameters` in the `Matrix` field are `Arrays` only, and that they are substituting `Parameters` of type `String` in the underlying `Task`. Related refactors were done in tektoncd#4841.
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
May 9, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. This includes validating that `Parameters` in the `Matrix` field are `Arrays` only, and that they are substituting `Parameters` of type `String` in the underlying `Task`. Related refactors were done in tektoncd#4841.
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
May 9, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. This includes validating that `Parameters` in the `Matrix` are substituting `Parameters` of type `String` in the underlying `Task`. Related: - tektoncd#4704 - tektoncd#4841
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
May 9, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. This includes validating that `Parameters` in the `Matrix` are substituting `Parameters` of type `String` in the underlying `Task`. Related: - tektoncd#4704 - tektoncd#4841
tekton-robot
pushed a commit
that referenced
this pull request
May 11, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. This includes validating that `Parameters` in the `Matrix` are substituting `Parameters` of type `String` in the underlying `Task`. Related: - #4704 - #4841
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In this change, we refactor the function that validates
Parametersin the
TaskRunreconciler in preparation for changes related toMatrix. The refactor mainly involves splitting up the lengthyfunction to make it easier to understand, maintain and reuse parts
of the logic.
There are no functional changes.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes