Fix test cases for validatePipelineParameterVariables function

[chuangw6]

Changes

Prior to this commit, many success tests were meaningless because they
just use the param names in the format of $(baz), $(foo-is-baz).
In validation, without using the format of $(params.<Name>), the
two examples above will be treated as just string literal instead of param
reference, and thus in fact validation agains using correct params
are not executed. That explains why there is no problem even though
declared param is actually called baz, but using $(bazzzz).

In this commit, the usage of param names is corrected to $(params.<Name>)
and type for ArrayOrString is added so that the param reference is really
validated.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in
  (if there are no user facing changes, use release note "NONE")

Release Notes

[lbernick]

Nice catch! I'm curious if the type: ParamTypeString is needed, since users don't have to declare the param type if it is a string

[chuangw6]

Nice catch! I'm curious if the type: ParamTypeString is needed, since users don't have to declare the param type if it is a string

Yes, that's needed here in the test because it's used in validatePipelineParametersVariablesInTaskParameters .

In yaml file, users don't have to specify the param type because the unmarshal operation will infer its type and set it i.e.

the following declaration will have string as the inferred type.

params:
- name: myString
   value: "test value"

the following declaration will have array as the inferred type.

params:
- name: myArray
   value: 
     - a
     - b

the following declaration will have object as the inferred type.

params:
- name: myObject
   value: 
     key1: "val1"
     key2: "val2"

[ywluogg]

/assign @ywluogg

[ywluogg]

Link this to #4723

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, ywluogg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abayer]

/lgtm

Merge won't go through until #4944 has merged.

[abayer]

/test pull-tekton-pipeline-integration-tests
/test pull-tekton-pipeline-alpha-integration-tests

[abayer]

/test pull-tekton-pipeline-integration-tests

[chuangw6]

/test pull-tekton-pipeline-build-tests

[chuangw6]

/retest

[abayer]

/retest

[chuangw6]

/test pull-tekton-pipeline-alpha-integration-tests

[chuangw6]

/test pull-tekton-pipeline-alpha-integration-tests

[chuangw6]

/test pull-tekton-pipeline-alpha-integration-tests

[afrittoli]

/kind misc