Validate the DAG when validating the pipeline spec (aka at creation) #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and rename the package from resources to dag Signed-off-by: Vincent Demeester <[email protected]>
knative-prow-robot
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
knative-prow-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
- Migrate the `DAG` struct and how it's build to the API - Update `dag` package to take `v1alpha1.DAG` as argument for Schedulable, … - Validate the DAG after `validateFrom`, and update `validateFrom` with no linear assumption Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
559-dag-validate-creation
branch
from
5e0ab82
to
b234812
Compare
|
The following is the coverage report on pkg/.
|
|
why are not happy with the solution @vdemeester? because you had to split things between |
vdemeester
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
dagrefactoring (and rename the package)DAGstruct and how it's build to the APIdagpackage to takev1alpha1.DAGas argument forSchedulable, …
validateFrom, and updatevalidateFromwith no linear assumption
@bobcatfish marking this one as
WIPas I'm not really a huge fan of the change 😅. I feel there is a better way than moving some part in theapi/v1alpha1packages (but I ain't sure)…Closes #559
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Includes docs (if user facing)See the contribution guide
for more details.
Release Notes