Cleanp - Adding a single variable for default configmaps. #6639
Conversation
tekton-robot
added
release-note-none
Prior, the New* function was called each time when we need to get the default configuration for the default, feature flags, metrics and spire configmap. Now, we created those variables first in corresponding file, and use a deepcopy of it each time. Signed-off-by: Chuang Wang <[email protected]>
chuangw6
force-pushed
the
cleanup-feature-flags
branch
from
1616c0d
to
a1227b7
Compare
|
/assign @jerop PTAL |
|
@chuangw6: GitHub didn't allow me to assign the following users: PTAL. Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @jerop |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-go-coverage |
|
/lgtm |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-go-coverage |
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
Changes
/kind cleanup
Prior, the New* function was called each time when we need to get the
default configuration for the default, feature flags, metrics and spire configmap.
Now, we created those variables first in corresponding file, and use a deepcopy
of it each time.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes