Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SequentialTasks & SequentialRuns Tests #6648

Merged

Conversation

EmmaMunley
Copy link
Contributor

@EmmaMunley EmmaMunley commented May 11, 2023

Changes

This PR refactors the tests: TestDAGExecutionQueueSequentialTasks and TestDAGExecutionQueueSequentialRuns to reduce the scope of the variables to individual test cases so that the test cases no longer influence each other.
/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. labels May 11, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2023
@lbernick
Copy link
Member

@EmmaMunley I think the explanation here is not quite right: the tests do currently pass in isolation and all at once, but the problem is that they influence each other by sharing state, modifying it, and resetting it at the end of the test. I would reword this commit message/PR description to explain that we're reducing the scope of these variables to individual test cases rather than all of them at once.

This commit refactors the tests: TestDAGExecutionQueueSequentialTasks and TestDAGExecutionQueueSequentialRuns to reduce the scope of the variables to individual test cases so that the test cases no longer influence each other.
@EmmaMunley EmmaMunley force-pushed the TestDAGExecutionQueueSequentialRuns branch from b130c02 to b856727 Compare May 11, 2023 16:47
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks for updating the commit message; please update the PR description too

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@tekton-robot tekton-robot merged commit c43a797 into tektoncd:main May 11, 2023
@EmmaMunley EmmaMunley deleted the TestDAGExecutionQueueSequentialRuns branch May 11, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants