Add results-from feature flag to config-feature-flags.yaml #6692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XS
|
/assign @pritidesai @jerop |
|
Thank you @pritidesai for catching this. |
|
/test pull-tekton-pipeline-build-tests |
|
@chitrangpatel please remove the trailing spaces, that's what is causing the build failure 
|
Prior to this the feature flag `results-from` was only mentioned in the documentation and missing from the config-feature-flags.yaml file. This PR fixes it and sets it to "termination-message" which is the default value.
chitrangpatel
force-pushed
the
add-results-from-to-configmap
branch
from
01d19cf
to
9d06f22
Compare
|
/lgtm |
jerop
approved these changes
May 23, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this the feature flag
results-fromwas only mentioned in the documentation and missing from theconfig-feature-flags.yamlfile. This PR fixes it and sets it totermination-messagewhich is the default value.Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind cleanup