Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the version of knative/pkg to something much more recent. #985

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Bump the version of knative/pkg to something much more recent. #985

merged 1 commit into from
Jun 17, 2019

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jun 14, 2019

Changes

We're a few months behind and are missing quite a few bug fixes and performance improvements.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jun 14, 2019
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 14, 2019
imjasonh
imjasonh requested changes Jun 14, 2019
View reviewed changes
pkg/logging/config.go Outdated Show resolved Hide resolved
@dlorenc
Bump the version of knative/pkg to something much more recent.
047996d 
We're a few months behind and are missing quite a few bug fixes and performance improvements.
@dlorenc
Copy link
Contributor Author

dlorenc commented Jun 17, 2019

/test pull-tekton-pipeline-integration-tests

@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2019
vdemeester
vdemeester approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit a23b508 into tektoncd:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh requested changes

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@vdemeester vdemeester

@imjasonh imjasonh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dlorenc @imjasonh @tekton-robot @vdemeester @googlebot