Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose UpdateID in an update handler #448

Closed
drewhoskins-temporal opened this issue Jun 4, 2024 · 3 comments · Fixed by #477
Closed

Expose UpdateID in an update handler #448

drewhoskins-temporal opened this issue Jun 4, 2024 · 3 comments · Fixed by #477
Milestone

Comments

@drewhoskins-temporal
Copy link

drewhoskins-temporal commented Jun 4, 2024

This will allow users to use it when they want a unique idempotent primary key for handlers.

@roxblnfk
Copy link
Collaborator

Looks like we already have it

/**
* Gets the unique ID of this update.
*/
public function getId(): string

@cretz
Copy link
Member

cretz commented Jun 20, 2024

I think that is for the client. This is for access inside the handler inside the workflow. Go is using context for this, other languages are using "async local" or similar. Unsure the best approach in PHP for providing contextual state to a handler (and things it may start) without affecting anything outside the handler.

@roxblnfk roxblnfk reopened this Jun 20, 2024
@roxblnfk
Copy link
Collaborator

This is for access inside the handler inside the workflow

Got it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants