Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unstaking from queued staking coins must not trigger rewards withdrawl #179

Closed
hallazzang opened this issue Oct 18, 2021 · 0 comments · Fixed by #180
Closed

fix: unstaking from queued staking coins must not trigger rewards withdrawl #179

hallazzang opened this issue Oct 18, 2021 · 0 comments · Fixed by #180
Assignees
@hallazzang
Labels
bug Something isn't working

Comments

@hallazzang
Copy link
Contributor

Currently, even if coins are unstaked from queue staking coins, not from already staked coins, rewards will be withdrawn.
This behavior might seem weird for some farmers, let's fix this: withdraw rewards when the amount of staked coins changes.
@hallazzang hallazzang added the bug Something isn't working label Oct 18, 2021
@hallazzang hallazzang self-assigned this Oct 18, 2021
hallazzang added a commit to hallazzang/farming that referenced this issue Oct 18, 2021
@hallazzang
fix: withdraw rewards only when staked amount changes
5a10561 
fixes tendermint#179
@hallazzang hallazzang mentioned this issue Oct 18, 2021
Merged
9 tasks
dongsam pushed a commit that referenced this issue Oct 18, 2021
@hallazzang
fix: withdraw rewards only when staked amount changes (#180)
343144e 
* chore: use helper methods in query endpoint

* fix: withdraw rewards only when staked amount changes

fixes #179

* test: add tests

* docs: update spec docs

* docs: update spec docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hallazzang hallazzang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: withdraw rewards only when staked amount changes hallazzang/farming
1 participant
@hallazzang