Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: implement simulation functions #83

Closed
wants to merge 19 commits into from

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Aug 18, 2021

Description

closes: #64

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz added the test and simulation test and simulation label Aug 18, 2021
@jaybxyz jaybxyz added this to the v1 milestone Aug 18, 2021
@jaybxyz jaybxyz self-assigned this Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #83 (783e3cc) into master (6dea151) will increase coverage by 5.99%.
The diff coverage is 77.35%.

❗ Current head 783e3cc differs from pull request most recent head 9fcb8e3. Consider uploading reports for the commit 9fcb8e3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   56.88%   62.88%   +5.99%     
==========================================
  Files          24       25       +1     
  Lines        1830     1972     +142     
==========================================
+ Hits         1041     1240     +199     
+ Misses        682      622      -60     
- Partials      107      110       +3     
Impacted Files Coverage Δ
x/farming/simulation/proposals.go 0.00% <0.00%> (ø)
x/farming/types/codec.go 0.00% <ø> (-4.77%) ⬇️
x/farming/module.go 53.84% <14.28%> (-1.90%) ⬇️
x/farming/simulation/operations.go 87.86% <82.75%> (+87.86%) ⬆️
x/farming/simulation/decoder.go 100.00% <100.00%> (+94.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dea151...9fcb8e3. Read the comment docs.

* master:
  fix: solve module, sdk issues
  test: improve code coverage
  test: add cli integration tests
  test: add integration cli test for ratio plan, stake, and unstake
  refactor: update description and use string slice flag for harvest for better developer experience
  feat: add integration test for create fixed amount plan command-line interface
@jaybxyz jaybxyz mentioned this pull request Sep 8, 2021
14 tasks
@jaybxyz
Copy link
Contributor Author

jaybxyz commented Sep 9, 2021

I will close this PR since it doesn't need two different PRs to implement simulation tests. I initially thought there wouldn't be any merge conflicts for public plans implementation but I realize there will be many conflicts when implementing the logics.

Since #98 is continuation of this PR, I will move there to continue.

@jaybxyz jaybxyz closed this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test and simulation test and simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Simulation functions
1 participant