Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow int de-/encoding #268

Open
liamsi opened this issue May 13, 2019 · 0 comments
Open

Disallow int de-/encoding #268

liamsi opened this issue May 13, 2019 · 0 comments

Comments

@liamsi
Copy link
Contributor

liamsi commented May 13, 2019

Amino allows to encode int for convenience and while the underlying varint encoding doesn't waste bytes on the wire it remains unclear how this translates to the existing proto3 types (int32, int64). Disallowing int would resolve this and probably is not a bad idea anyways (as int is platform dependant). The SDK and the tendermint team seem onboard with doing the necessary changes.

Alternatively, always assume (proto) int64 when int is used on the go side (and err on 32 b it platforms).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant