Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix updated to be compatible with LTS14.4 #254

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

SaeedHK
Copy link
Contributor

@SaeedHK SaeedHK commented Feb 14, 2020

With @curiousleo, we have noticed some outdated versions in installation by nix.
We did the following changes:

  • nix/update updated to pull from the nix release 19.09
  • shell.nix updated to use ghc865 as default for ghc (since LTS14.4 uses ghc865).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@SaeedHK SaeedHK changed the title nix updates to compatible with LTS14.4 nix updated to be compatible with LTS14.4 Feb 14, 2020
@SaeedHK
Copy link
Contributor Author

SaeedHK commented Feb 14, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@@ -11,8 +11,8 @@ let
pkgs = import nixpkgs {};
in
pkgs.haskell.lib.buildStackProject {
# Either use specified GHC or use GHC 8.6.4 (which we need for LTS 13.13)
ghc = if isNull ghc then pkgs.haskell.compiler.ghc864 else ghc;
# Either use specified GHC or use GHC 8.6.5 (which we need for LTS 14.4)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Brings this file in line with #248)

@blackgnezdo
Copy link
Contributor

I don't use nor understand Nix, but since you guys think it's good, I'll merge.

@blackgnezdo blackgnezdo merged commit f07c7f2 into tensorflow:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants