Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer review by Smita #1

Open
17 tasks
SmitaG1995 opened this issue Apr 7, 2020 · 0 comments
Open
17 tasks

Peer review by Smita #1

SmitaG1995 opened this issue Apr 7, 2020 · 0 comments

Comments

@SmitaG1995
Copy link

  • Documentation:
    • title and abstract of the project (max 300 words) Good abstract
    • includes instructions on how to run the notebook No instructions found in Read me. Can you provide the instruction in read me instead of in the notebook
    • includes the required packages in an environment.yml file It would be better if you rename the file to environment.yml
    • includes a brief explanation of the reason each package/library was used Yes
    • includes rich documentation using Markdown (equations, tables, links, images or videos) Yes nice description
    • is reproducible, i.e., someone else should be able to redo the steps I got an error 'No module scipy found' Maybe something wrong with environment file?
  • Input/Output:
    • uses pandas to read large data sets or numpy to load data from text files Yes
    • uses pandas to save to disk the processed or generated data Yes
  • Scientific computing/data processing:
    • performs numerical operations (numpy, scipy, pandas) or manipulates, groups, and aggregates a data set (pandas) Yes
  • Data visualization:
    • includes at least one composite plot (inset or multiple panels) I couldn't make plots because of the scipy error
    • produces publication ready quality figures (see here for an editorial guide on Graphical Excellence): I couldn't make plots because of the scipy error
  • Version control, sharing, and archiving:
    • is archived in a repository with a digital object identifier (DOI) Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant