android-tools: clean up and fix fastboot patches #10561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
finagolfin,
Grimler91,
landfillbaby,
thunder-coding and
xtkoba
as code owners
|
I suggest that the clean-up part and the fix part be separated and be made into two commits, unless they are inseparable from each other. Also add an appropriate comment to each commit (it should be OK to just copy and paste the current description in this PR). |
ghost
changed the title
thank you sir, done |
added 2 commits
May 12, 2022 19:50
* switch to global struct for managing libusb_context Signed-off-by: Ookiineko <[email protected]>
* when the usb is disconnected, the fd is still valid, * thus causing LinuxUsbTransport::WaitForDisconnect to wait until the 3s timeout * now we check if the fd's fstat->st_nlink is less than 1 to detect a disconnection Signed-off-by: Ookiineko <[email protected]> android-tools: bump TERMUX_PKG_REVISION Signed-off-by: Ookiineko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really sorry to disturb again
I found that if I switch to the global struct, I can make the fastboot patch only modify 2 files
Also, when the usb is disconnected, the fd is still valid,
thus causing LinuxUsbTransport::WaitForDisconnect to wait until the 3s timeout.
I now check if the fd's fstat->st_nlink is less than 1 to solve this problem
Then, I made a few more changes,
now you can use fastboot with Termux-usb even with root (although it may be useless xddd)
Actual flashing