Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new package: nerdfix #18204

Merged
merged 1 commit into from
Nov 12, 2023
Merged

new package: nerdfix #18204

merged 1 commit into from
Nov 12, 2023

Conversation

TomJo2000
Copy link
Member

@TomJo2000 TomJo2000 commented Oct 9, 2023

Adds the nerdfix utility for replacing obsolete NerdFont glyphs.

It would probably be prudent to package an interactive utility for replacing obsolete NerdFont 2.3.x glyphs, considering termux/termux-styling just updated the fonts to NerdFonts 3.0.2

nerdfix is already packaged on the AUR, Homebrew and Nixpkgs.

I have chosen to package the latest commit 76bf959 as of today,
as there are several improvements over the 0.3.1 release from May.

Edit: 0.4.0 was released while this PR was pending.

I think it would be better to put this package in the main repo rather than the TUR
as it makes sense to set it as a TERMUX_PKG_SUGGESTS
for packages often used in conjunction with NerdFonts, such as starship.
(If I missed other such packages please suggest them.)


PR checklist

  • Builds locally (all architectures
  • Builds on CI/CD
  • Add as a TERMUX_PKG_SUGGESTS to relavant packages
    • starship
  • Tested on-device (Android 10, Aarch64)

Copy link
Member

@licy183 licy183 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you please bump this package to 0.4.0? After that, I'll merge this PR.

@TomJo2000
Copy link
Member Author

Sorry, messed up a command, fixing it right now.

@TomJo2000
Copy link
Member Author

Sorry about that, messed up the push the first time around, should be fixed now.

@licy183 licy183 merged commit 9699e6d into termux:master Nov 12, 2023
@TomJo2000 TomJo2000 deleted the nerdfix branch November 12, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants