Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Bottlerocket example #1296

Merged
merged 1 commit into from
May 19, 2021

Conversation

Andrey9kin
Copy link
Contributor

@Andrey9kin Andrey9kin commented Apr 11, 2021

PR o'clock

Description

There were a couple of PRs requesting changes to the module to run AWS Bottlerocket based nodes. (for example #840)
I got Bottlerocket up and running without any changes to the module so wanted to document it and possibly prevent
other PRs from trying to introduce changes that could be easily avoided.

Checklist

@Andrey9kin Andrey9kin changed the title Bottlerocket example docs: Bottlerocket example Apr 11, 2021
@barryib barryib changed the title docs: Bottlerocket example docs: Add Bottlerocket example May 19, 2021
@barryib barryib self-assigned this May 19, 2021
examples/bottlerocket/variables.tf Outdated Show resolved Hide resolved
examples/bottlerocket/main.tf Outdated Show resolved Hide resolved
@barryib
Copy link
Member

barryib commented May 19, 2021

@Andrey9kin thanks for working on this. Can you please rebase your branch from master ?

Signed-off-by: Andrey Devyatkin <[email protected]>
@Andrey9kin
Copy link
Contributor Author

@barryib rebased + fixed comments.. Thanks for looking into it!

@barryib barryib merged commit 70f6150 into terraform-aws-modules:master May 19, 2021
@barryib
Copy link
Member

barryib commented May 19, 2021

Thanks @Andrey9kin for your contribution.

@Andrey9kin
Copy link
Contributor Author

@barryib my pleasure. hope it will be useful for the community!

barryib pushed a commit to barryib/terraform-aws-eks that referenced this pull request May 20, 2021
ArchiFleKs pushed a commit to ArchiFleKs/terraform-aws-eks that referenced this pull request Jun 1, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants