support for client.authentication.k8s.io/v1beta1

[vsamidurai]

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

support for client.authentication.k8s.io/v1beta1 kubeconfig, when we create a new EKS cluster. client.authentication.k8s.io/v1beta1 API available for a while. should be able to generate kubeconfig with v1beta1 api.

Describe the solution you'd like.

Describe alternatives you've considered.

Additional context

[daroga0002]

there is PR #1235 addressing this

[vsamidurai]

it would be great if this PR addresses

terraform-aws-eks/templates/kubeconfig.tpl

Line 23 in e3216e3

apiVersion: client.authentication.k8s.io/v1alpha1

API version configurable.

[daroga0002]

I think until awscli and AWS in official docs is showing this as preference https://docs.aws.amazon.com/eks/latest/userguide/create-kubeconfig.html I don`t see a reason to change it.

What exactly this change will help or solve you? could you pass any benefits here?

[vsamidurai]

Recently, aws-cli switched to v1beta1 and reverted back to v1alpha1 in this PR aws/aws-cli#6309. Also as per this PR comment, kubernetes/kubernetes#102890 (comment) kubernetes drops v1alpha. so looking for v1beta support in terraform and aws cli.

[daroga0002]

This change will be breaking change as we will update user_data on each worker, so looking into the PRs which you provided I see it will become effective in Kubernetes 1.22, AWS cli seems be still not ready so we probably need hold on until those parties will make their changes and then change it here in major version as it will be breaking change.

very good catch 👍

[daroga0002]

@vsamidurai does you will be able to open a PR and test changes?

[vsamidurai]

@daroga0002 sure, i'll open a PR and test this change.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[daroga0002]

not stale

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[daroga0002]

#1550 was merged

[vsamidurai]

#1550 was merged

Thank you @daroga0002

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.