Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing mixed_instances_policy parameter to the root module #1808

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Jan 24, 2022

Description

  • add missing mixed_instances_policy parameter to the root module

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    • Updated self-managed-node-group example for testing and validation

@bryantbiggs bryantbiggs changed the title fix: add missing mixed_instances_policy parameter to the root module fix: Add missing mixed_instances_policy parameter to the root module Jan 24, 2022
@bryantbiggs bryantbiggs marked this pull request as draft January 24, 2022 15:25
@bryantbiggs
Copy link
Member Author

Looks good
image

@bryantbiggs bryantbiggs marked this pull request as ready for review January 24, 2022 16:05
@antonbabenko antonbabenko merged commit 4af77f2 into terraform-aws-modules:master Jan 24, 2022
antonbabenko pushed a commit that referenced this pull request Jan 24, 2022
### [18.2.3](v18.2.2...v18.2.3) (2022-01-24)

### Bug Fixes

* Add missing `mixed_instances_policy` parameter to the root module ([#1808](#1808)) ([4af77f2](4af77f2))
@antonbabenko
Copy link
Member

It should have been feat, not fix... but ok :)

@antonbabenko
Copy link
Member

This PR is included in version 18.2.3 🎉

@bryantbiggs bryantbiggs deleted the fix/mixed-instance-policy branch January 24, 2022 20:34
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mixed_instances_policy is not working
2 participants