Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add compact() to aws_auth_configmap_yaml for when node groups are set to create = false #2029

Conversation

bryantbiggs
Copy link
Member

Description

  • Add compact() to aws_auth_configmap_yaml for when node groups are set to create = false

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko merged commit c173ba2 into terraform-aws-modules:master Apr 20, 2022
@bryantbiggs bryantbiggs deleted the fix/auth-configmap-template branch April 20, 2022 16:14
antonbabenko pushed a commit that referenced this pull request Apr 20, 2022
### [18.20.3](v18.20.2...v18.20.3) (2022-04-20)

### Bug Fixes

* Add `compact()` to `aws_auth_configmap_yaml` for when node groups are set to `create = false` ([#2029](#2029)) ([c173ba2](c173ba2))
@antonbabenko
Copy link
Member

This PR is included in version 18.20.3 🎉

spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Apr 26, 2022
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Apr 26, 2022
### [18.20.3](terraform-aws-modules/terraform-aws-eks@v18.20.2...v18.20.3) (2022-04-20)

### Bug Fixes

* Add `compact()` to `aws_auth_configmap_yaml` for when node groups are set to `create = false` ([terraform-aws-modules#2029](terraform-aws-modules#2029)) ([c173ba2](terraform-aws-modules@c173ba2))
it-without-politics pushed a commit to it-without-politics/terraform-aws-eks that referenced this pull request May 23, 2022
it-without-politics pushed a commit to it-without-politics/terraform-aws-eks that referenced this pull request May 23, 2022
### [18.20.3](terraform-aws-modules/terraform-aws-eks@v18.20.2...v18.20.3) (2022-04-20)

### Bug Fixes

* Add `compact()` to `aws_auth_configmap_yaml` for when node groups are set to `create = false` ([terraform-aws-modules#2029](terraform-aws-modules#2029)) ([c173ba2](terraform-aws-modules@c173ba2))
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
### [18.20.3](terraform-aws-modules/terraform-aws-eks@v18.20.2...v18.20.3) (2022-04-20)

### Bug Fixes

* Add `compact()` to `aws_auth_configmap_yaml` for when node groups are set to `create = false` ([#2029](terraform-aws-modules/terraform-aws-eks#2029)) ([ffeaf50](terraform-aws-modules/terraform-aws-eks@ffeaf50))
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid template interpolation value; The expression result is null.
2 participants