Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update CloudWatch log group creation deny policy to use wildcard #2267

Merged

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Oct 11, 2022

Description

  • Replace CloudWatch log group ARN in cluster IAM role policy to use a "*" instead

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally acceptable because this is a deny action where we are denying more with a wildcard than an ARN. Thanks, lets hope this does the trick!

@bryantbiggs bryantbiggs merged commit ac4d549 into terraform-aws-modules:master Oct 11, 2022
@bryantbiggs bryantbiggs deleted the fix/cloudwatch-logs branch October 11, 2022 20:28
antonbabenko pushed a commit that referenced this pull request Oct 11, 2022
### [18.30.1](v18.30.0...v18.30.1) (2022-10-11)

### Bug Fixes

* Update CloudWatch log group creation deny policy to use wildcard ([#2267](#2267)) ([ac4d549](ac4d549))
@antonbabenko
Copy link
Member

This PR is included in version 18.30.1 🎉

@haarchri
Copy link
Contributor

Yeah again ;)

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants