Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Snapshot permissions issue for Karpenter submodule #2649

Conversation

sanjinp
Copy link
Contributor

@sanjinp sanjinp commented Jun 9, 2023

Description

This commit 2648

Motivation and Context

With current permissions we are unable to use SnapshotID with Karpenter provisioner

#2648

Breaking Changes

No

How Has This Been Tested?

Manually, by using local module with fixed permissions

@sanjinp sanjinp changed the title fix: snapshot permirrions issue for karpenter submodule fix: snapshot permissions issue for karpenter submodule Jun 9, 2023
@sanjinp sanjinp changed the title fix: snapshot permissions issue for karpenter submodule fix: Snapshot permissions issue for Karpenter submodule Jun 9, 2023
@bryantbiggs
Copy link
Member

How has this been tested and validated?

@sanjinp
Copy link
Contributor Author

sanjinp commented Jun 9, 2023

How has this been tested and validated?

By editing local karpenter submodule with proposed change and applying it, and successfully running an ec2 machine with referenced volume snapshot. With applied change, karpenter responds with:

2023-06-09T15:31:04.395Z	INFO	controller.provisioner	launching machine with 1 pods requesting {"cpu":"2555m","memory":"13048Mi","nvidia.com/gpu":"1","pods":"8"} from types g4dn.xlarge	{"commit": "698f22f-dirty", "provisioner": "gpu"}
2023-06-09T15:31:04.707Z	DEBUG	controller.provisioner.cloudprovider	created launch template	{"commit": "698f22f-dirty", "provisioner": "gpu", "launch-template-name": "karpenter.k8s.aws/17335910175306066370", "launch-template-id": "lt-002942817857840df"}
2023-06-09T15:31:06.625Z	INFO	controller.provisioner.cloudprovider	launched instance	{"commit": "698f22f-dirty", "provisioner": "gpu", "id": "i-0bfd700287583ed01", "hostname": "ip-10-41-68-75.us-east-2.compute.internal", "instance-type": "g4dn.xlarge", "zone": "us-east-2c", "capacity-type": "on-demand", "capacity": {"cpu":"4","ephemeral-storage":"40Gi","memory":"15155Mi","nvidia.com/gpu":"1","pods":"29"}}
2023-06-09T15:32:06.391Z	DEBUG	controller.node	added TTL to empty node	{"commit": "698f22f-dirty", "node": "ip-10-41-68-75.us-east-2.compute.internal"}

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@bryantbiggs bryantbiggs merged commit 6217d0e into terraform-aws-modules:master Jun 9, 2023
antonbabenko pushed a commit that referenced this pull request Jun 9, 2023
### [19.15.3](v19.15.2...v19.15.3) (2023-06-09)

### Bug Fixes

* Snapshot permissions issue for Karpenter submodule ([#2649](#2649)) ([6217d0e](6217d0e))
@antonbabenko
Copy link
Member

This PR is included in version 19.15.3 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants