Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow enable/disable of EKS pod identity for the Karpenter controller #2902

Conversation

tculp
Copy link
Contributor

@tculp tculp commented Feb 5, 2024

Description

Made a new variable in the karpenter submodule "enable_pod_identity" which allows pod identities to be disabled.

Motivation and Context

Pod identities are not currently available in all partitions, and this principal being present in these locations causes the module to fail.

Breaking Changes

No, the default is set to true which has the same behavior as before

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@tculp tculp changed the title Made EKS pod identities for the controller role toggleable [feat] Made EKS pod identities for the controller role toggleable Feb 5, 2024
@tculp tculp changed the title [feat] Made EKS pod identities for the controller role toggleable feat: Made EKS pod identities for the controller role toggleable Feb 5, 2024
@bryantbiggs bryantbiggs changed the title feat: Made EKS pod identities for the controller role toggleable feat: Allow enable/disable of EKS pod identity for the Karpenter controller Feb 6, 2024
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@bryantbiggs bryantbiggs merged commit cc6919d into terraform-aws-modules:master Feb 6, 2024
20 checks passed
antonbabenko pushed a commit that referenced this pull request Feb 6, 2024
## [20.2.0](v20.1.1...v20.2.0) (2024-02-06)

### Features

* Allow enable/disable of EKS pod identity for the Karpenter controller ([#2902](#2902)) ([cc6919d](cc6919d))
@antonbabenko
Copy link
Member

This PR is included in version 20.2.0 🎉

@tculp tculp deleted the karpenter-toggleable-pod-identities branch February 6, 2024 14:42
Copy link

github-actions bot commented Mar 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Karpenter] Allow pod-identities statement to be disabled
3 participants