feat: Add SourceArn condition to Fargate profile trust policy
#3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
changed the title
SourceArn condition to fargate-profile assume_role_policySourceArn condition to Fargate profile trust policy
bryantbiggs
approved these changes
May 16, 2024
bryantbiggs
merged commit a070d7b
into
terraform-aws-modules:master
17 of 18 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
May 16, 2024
## [20.11.0](v20.10.0...v20.11.0) (2024-05-16) ### Features * Add `SourceArn` condition to Fargate profile trust policy ([#3039](#3039)) ([a070d7b](a070d7b))
|
This PR is included in version 20.11.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested in AWS docs to prevent the security issue known as the confused deputy problem, adds
SourceArncondition tofargate-profilemodule'sassume_role_policyMotivation and Context
Fixes #3038.
Suggested IAM trust policy per AWS docs "to avoid a confused deputy security problem."
Breaking Changes
Potentially breaks workflows where users may be using/assuming the IAM role generated by
fargate-profilein an unintended manner, namely from other EKS instances.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request