Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not recreate cluster when no SG given #798

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

dpiddockcmp
Copy link
Contributor

@dpiddockcmp dpiddockcmp commented Mar 14, 2020

PR o'clock

Description

Setting cluster_create_security_group = false and not setting cluster_security_group_id causes the cluster to be recreated on every apply.

I did try setting cluster_security_group_id = null but then terraform complains that there's a null item inside a list and that I'm a very bad person for doing something so rude.

Fixes #797

Checklist

@dpiddockcmp dpiddockcmp changed the title Do not recreate cluster when no SG given fix: Do not recreate cluster when no SG given Mar 17, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not specifying or creating cluster SG causes cluster recreation on every apply
3 participants