Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change EKS default version to 1.16 #857

Merged
merged 2 commits into from
May 6, 2020
Merged

feat: Change EKS default version to 1.16 #857

merged 2 commits into from
May 6, 2020

Conversation

sc250024
Copy link
Contributor

@sc250024 sc250024 commented May 2, 2020

PR o'clock

Description

Upgrading module to support EKS 1.16. Resolves issue #856.

Checklist

dpiddockcmp
dpiddockcmp suggested changes May 3, 2020
View reviewed changes
Copy link
Contributor

@dpiddockcmp dpiddockcmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes are needed to the module to support 1.16. Users can use it by setting the cluster_version variable. You're changing the module's default version and the PR title should reflect that.

versions.tf Outdated Show resolved Hide resolved
@sc250024 sc250024 changed the title feat(eks): Support EKS 1.16 feat(eks): Change EKS version to 1.16 May 3, 2020
@sc250024
Copy link
Contributor Author

sc250024 commented May 3, 2020

No changes are needed to the module to support 1.16. Users can use it by setting the cluster_version variable. You're changing the module's default version and the PR title should reflect that.

Changed.

@sc250024 sc250024 mentioned this pull request May 3, 2020
Closed
4 tasks
barryib
barryib reviewed May 4, 2020
View reviewed changes
docs/spot-instances.md Outdated Show resolved Hide resolved
@barryib barryib changed the title feat(eks): Change EKS version to 1.16 feat: Change EKS default version to 1.16 May 4, 2020
@barryib barryib merged commit 99f59bf into terraform-aws-modules:master May 6, 2020
@barryib
Copy link
Member

barryib commented May 6, 2020

Nice. Thanks @sc250024 for your contribution.

@sc250024 sc250024 deleted the feat-Eks116 branch May 6, 2020 15:23
@sc250024
Copy link
Contributor Author

sc250024 commented May 6, 2020

Nice. Thanks @sc250024 for your contribution.

Thank you!

This was referenced May 7, 2020
Merged
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barryib barryib barryib approved these changes

@dpiddockcmp dpiddockcmp Awaiting requested review from dpiddockcmp

@max-rocket-internet max-rocket-internet Awaiting requested review from max-rocket-internet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sc250024 @barryib @max-rocket-internet @dpiddockcmp