Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add customizable Auto Scaling Group health check type #1118

Merged
merged 2 commits into from
Dec 22, 2020
Merged

feat: Add customizable Auto Scaling Group health check type #1118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b6c1c5
improvement: Customizable ASG health check type
Nov 23, 2020
bafbe09
Merge branch 'master' into ASG-health-check-type
barryib Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions local.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ locals {
asg_initial_lifecycle_hooks = [] # Initital lifecycle hook for the autoscaling group.
asg_recreate_on_change = false # Recreate the autoscaling group when the Launch Template or Launch Configuration change.
default_cooldown = null # The amount of time, in seconds, after a scaling activity completes before another scaling activity can start.
health_check_type = null # Controls how health checking is done. Valid values are "EC2" or "ELB".
health_check_grace_period = null # Time in seconds after instance comes into service before checking health.
instance_type = "m4.large" # Size of the workers instances.
spot_price = "" # Cost of spot instance.
Expand Down
5 changes: 5 additions & 0 deletions workers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ resource "aws_autoscaling_group" "workers" {
"default_cooldown",
local.workers_group_defaults["default_cooldown"]
)
health_check_type = lookup(
var.worker_groups[count.index],
"health_check_type",
local.workers_group_defaults["health_check_type"]
)
health_check_grace_period = lookup(
var.worker_groups[count.index],
"health_check_grace_period",
Expand Down
5 changes: 5 additions & 0 deletions workers_launch_template.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ resource "aws_autoscaling_group" "workers_launch_template" {
"default_cooldown",
local.workers_group_defaults["default_cooldown"]
)
health_check_type = lookup(
var.worker_groups_launch_template[count.index],
"health_check_type",
local.workers_group_defaults["health_check_type"]
)
health_check_grace_period = lookup(
var.worker_groups_launch_template[count.index],
"health_check_grace_period",
Expand Down