Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ignore NG's Launch Template Version Change #1528

Conversation

Efrat19
Copy link

@Efrat19 Efrat19 commented Aug 12, 2021

PR o'clock

As a heavy user of this module, every time I run the terraform apply I get frustrated by the fact I all of my managed nodegroups are updated, regardless of the change I made to the TF stack.
The update is to the LT version, from "2" to "$Latest", even though in my configuration the version is already set to "latest":

My configuration look like this:


module "eks" {
  source          = "terraform-aws-modules/eks/aws"
  .....
  workers_group_defaults = {
    .....
    create_launch_template   = true
    launch_template_version = "$Latest"
  }
}

But when I run terraform plan, I see that terraform is aiming to change the version:
image

Description

I added the LT version to the ignore list in hope this may help other people using this module

@johngmyers
Copy link

#1447 looks like a much better fix, since it handles the case where the specified launch template version is not "$Latest".

@Efrat19
Copy link
Author

Efrat19 commented Aug 15, 2021

I agree, thanks!

@Efrat19 Efrat19 closed this Aug 15, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants