Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed launch_templates_with_managed_node_group example #1599

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
resource "aws_iam_service_linked_role" "autoscaling" {
aws_service_name = "autoscaling.amazonaws.com"
description = "Default Service-Linked Role enables access to AWS Services and Resources used or managed by Auto Scaling"
custom_suffix = "lt_with_managed_node_groups" # the full name is "AWSServiceRoleForAutoScaling_lt_with_managed_node_groups" < 64 characters
}

#data "aws_caller_identity" "current" {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ resource "aws_launch_template" "default" {
}
}

instance_type = var.instance_type

monitoring {
enabled = true
}
Expand Down
2 changes: 2 additions & 0 deletions examples/launch_templates_with_managed_node_groups/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ module "eks" {
launch_template_id = aws_launch_template.default.id
launch_template_version = aws_launch_template.default.default_version

instance_types = var.instance_types

additional_tags = {
CustomTag = "EKS example"
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
variable "instance_type" {
description = "Instance type"
variable "instance_types" {
description = "Instance types"
# Smallest recommended, where ~1.1Gb of 2Gb memory is available for the Kubernetes pods after ‘warming up’ Docker, Kubelet, and OS
type = string
default = "t3.small"
type = list(string)
default = ["t3.small"]
}